Merge pull request #9 from librenms/testing

Add testing for helm chart and lint cleanup

.github/workflows/chart-testing.yml

@@ -0,0 +1,51 @@
+name: Lint and Test Charts
+
+on: pull_request
+
+jobs:
+  lint-test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - name: Set up Helm
+        uses: azure/setup-helm@v4.2.0
+        with:
+          version: v3.14.4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
+          check-latest: true
+
+      - name: Set up chart-testing
+        uses: helm/chart-testing-action@v2.6.1
+
+      - name: Add repositories
+        run: |
+          for dir in $(ls -d charts/*/); do
+            helm dependency list $dir 2> /dev/null | tail +2 | head -n -1 | awk '{ print "helm repo add " $1 " " $3 }' | while read cmd; do $cmd; done
+          done
+
+      - name: Run chart-testing (list-changed)
+        id: list-changed
+        run: |
+          changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
+          if [[ -n "$changed" ]]; then
+            echo "changed=true" >> "$GITHUB_OUTPUT"
+          fi
+
+      - name: Run chart-testing (lint)
+        if: steps.list-changed.outputs.changed == 'true'
+        run: ct lint --target-branch ${{ github.event.repository.default_branch }}
+
+      - name: Create kind cluster
+        if: steps.list-changed.outputs.changed == 'true'
+        uses: helm/kind-action@v1.10.0
+
+      - name: Run chart-testing (install)
+        if: steps.list-changed.outputs.changed == 'true'
+        run: ct install --target-branch ${{ github.event.repository.default_branch }} --skip-clean-up

charts/librenms/Chart.lock

@@ -5,5 +5,5 @@ dependencies:
 - name: mysql
   repository: https://charts.bitnami.com/bitnami
   version: 10.3.0
-digest: sha256:7b8a3f1182b70837c842c8a9fe7c1fa913cadd6800f1f780f94c357af7fca21f
+digest: sha256:f1e63eec3d96520ef7cd365ece9a281d57e48f811fd9e19d47baefa37fceee76
-generated: "2024-07-05T12:50:36.211666249Z"
+generated: "2024-07-09T11:51:38.284682+02:00"

charts/librenms/Chart.yaml

@@ -2,14 +2,17 @@ apiVersion: v2
 name: librenms
 description: LibreNMS is an autodiscovering PHP/MySQL-based network monitoring system.
 type: application
-version: 3.10.0
+version: 3.10.1
 appVersion: "24.5.0"
+maintainers:
+  - name: TheChef23
+    url: https://github.com/TheChef23
 dependencies:
   - name: redis
     version: "~19.6.0"
     repository: "https://charts.bitnami.com/bitnami"
-    when: redis.enabled == true
+    condition: redis.enabled
   - name: mysql
     version: "~10.3.0"
     repository: "https://charts.bitnami.com/bitnami"
-    when: mysql.enabled == true
+    condition: mysql.enabled

charts/librenms/ci/test-values.yaml

@@ -0,0 +1,2 @@
+librenms:
+  appkey: base64:RTMmh+i10E2RMcDxookMu47BTzJQy87hOU+k/zcuPnA=

charts/librenms/values.yaml

@@ -9,7 +9,7 @@ librenms:
   # Laravel appkey used by LibreNMS, a default is set for useability it is
   # recommended to replace this with your own key
   # THIS A REQUIRED SETTINGS
-  appkey: 
+  appkey:
 
   # Timezone used by librenms for communication with RRD cached
   timezone: UTC
@@ -20,9 +20,7 @@ librenms:
   configuration: |-
     $config['distributed_poller_group']          = '0';
     $config['distributed_poller']                = true;
-  
 
-  
   # Frontend container configurations options
   frontend:
     replicas: 1
@@ -47,9 +45,9 @@ librenms:
       #   memory: 200M
 
   # SNMP network discovery scanner cron job. This job is optional and only use
-  # when having snmp network discovery enabled. For this to work either set the 
+  # when having snmp network discovery enabled. For this to work either set the
   # 'nets' confifuration in the custom config on in the admin interface
-  # See the following link for more information: 
+  # See the following link for more information:
   # https://docs.librenms.org/Extensions/Auto-Discovery/
   snmp_scanner:
     enabled: false
@@ -65,7 +63,7 @@ librenms:
   extraEnvs: {}
 
   # RRD cached is the tool that allows for distributed polling and is mandatory
-  # in this LibreNMS helm chart. See the rrdcached documentation for more 
+  # in this LibreNMS helm chart. See the rrdcached documentation for more
   # information: https://oss.oetiker.ch/rrdtool/doc/rrdcached.en.html
   rrdcached:
     image:
@@ -97,7 +95,7 @@ librenms:
     # Extra environment variable for RRDCACHED container
     extraEnvs: {}
 
-# Configuration for MySQL dependency chart by Bitnami. See their chart for 
+# Configuration for MySQL dependency chart by Bitnami. See their chart for
 # more information: https://github.com/bitnami/charts/tree/master/bitnami/mysql
 mysql:
   enabled: true
@@ -105,7 +103,7 @@ mysql:
     username: librenms
     database: librenms
 
-# Configuration for redis dependency chart by Bitnami. See their chart for 
+# Configuration for redis dependency chart by Bitnami. See their chart for
 # more information: https://github.com/bitnami/charts/tree/master/bitnami/redis
 redis:
   enabled: true
@@ -119,4 +117,4 @@ redis:
   master:
     disableCommands: []
 
-  architecture: standalone
+  architecture: standalone