diff --git a/charts/meta-monitoring/src/dashboards/loki-logs.json b/charts/meta-monitoring/src/dashboards/loki-logs.json index 32b8e52..64cf963 100644 --- a/charts/meta-monitoring/src/dashboards/loki-logs.json +++ b/charts/meta-monitoring/src/dashboards/loki-logs.json @@ -801,7 +801,7 @@ "steppedLine": false, "targets": [ { - "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", pod=~\"$deployment.*\", pod=~\"$pod\", container=~\"$container\" } |logfmt| level=\"$level\" |= \"$filter\" | __error__=\"\" [$__auto])) by (level)", + "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", pod=~\"$deployment.*\", pod=~\"$pod\", container=~\"$container\" } |logfmt| level=\"$level\" |= \"$filter\" | __error__=\"\" [$__interval])) by (level)", "intervalFactor": 3, "legendFormat": "{{level}}", "refId": "A" diff --git a/charts/meta-monitoring/src/dashboards/loki-operational.json b/charts/meta-monitoring/src/dashboards/loki-operational.json index 751f77a..2680135 100644 --- a/charts/meta-monitoring/src/dashboards/loki-operational.json +++ b/charts/meta-monitoring/src/dashboards/loki-operational.json @@ -1997,7 +1997,7 @@ "steppedLine": false, "targets": [ { - "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*distributor.*|(loki|enterprise-logs)-write|loki-single-binary)\"} | logfmt | level=\"error\"[$__auto]))", + "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*distributor.*|(loki|enterprise-logs)-write|loki-single-binary)\"} | logfmt | level=\"error\"[$__interval]))", "refId": "A" } ], @@ -2690,7 +2690,7 @@ "steppedLine": false, "targets": [ { - "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*ingester.*|(loki|enterprise-logs)-write|loki-single-binary)\"} | logfmt | level=\"error\"[$__auto]))", + "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*ingester.*|(loki|enterprise-logs)-write|loki-single-binary)\"} | logfmt | level=\"error\"[$__interval]))", "refId": "A" } ], @@ -3635,7 +3635,7 @@ "steppedLine": false, "targets": [ { - "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*querier.*|(loki|enterprise-logs)-read|loki-single-binary)\"} | logfmt | level=\"error\"[$__auto]))", + "expr": "sum(rate({cluster=\"$cluster\", namespace=\"$namespace\", job=~\"($namespace)/(.*querier.*|(loki|enterprise-logs)-read|loki-single-binary)\"} | logfmt | level=\"error\"[$__interval]))", "refId": "A" } ], diff --git a/charts/meta-monitoring/templates/agent/_helpers-agent.tpl b/charts/meta-monitoring/templates/agent/_helpers-agent.tpl index 802890c..a6f5661 100644 --- a/charts/meta-monitoring/templates/agent/_helpers-agent.tpl +++ b/charts/meta-monitoring/templates/agent/_helpers-agent.tpl @@ -9,7 +9,7 @@ {{- define "agent.all_namespaces" -}} {{- $list := list }} {{- range .Values.namespacesToMonitor }} -{{- $list = append $list (printf "\"%s\"" .) }} +{{- $list = append $list (printf "%s" .) }} {{- end }} {{- $list = append $list .Release.Namespace }} {{- join "|" $list }} diff --git a/charts/meta-monitoring/templates/agent/config.yaml b/charts/meta-monitoring/templates/agent/config.yaml index 969062a..8822957 100644 --- a/charts/meta-monitoring/templates/agent/config.yaml +++ b/charts/meta-monitoring/templates/agent/config.yaml @@ -40,10 +40,12 @@ data: {{- if or .Values.local.logs.enabled .Values.cloud.logs.enabled }} // Logs + {{- if .Values.cloud.logs.enabled }} remote.kubernetes.secret "logs_credentials" { namespace = "{{- $.Release.Namespace -}}" name = "{{- .Values.cloud.logs.secret -}}" } + {{- end }} loki.source.kubernetes "pods" { clustering { @@ -80,10 +82,12 @@ data: {{- if or .Values.local.metrics.enabled .Values.cloud.metrics.enabled }} // Metrics + {{- if .Values.cloud.metrics.enabled }} remote.kubernetes.secret "metrics_credentials" { namespace = "{{- $.Release.Namespace -}}" name = "{{- .Values.cloud.metrics.secret -}}" } + {{- end }} discovery.kubernetes "metric_pods" { role = "pod" @@ -139,7 +143,7 @@ data: rule { source_labels = ["namespace"] - regex = "{{ include "agent.all_namespaces" . }}"" + regex = "{{ include "agent.all_namespaces" . }}" action = "keep" } @@ -278,10 +282,12 @@ data: {{- if or .Values.local.traces.enabled .Values.cloud.traces.enabled }} // Traces + {{- if .Values.cloud.traces.enabled }} remote.kubernetes.secret "traces_credentials" { namespace = "{{- $.Release.Namespace -}}" name = "{{- .Values.cloud.traces.secret -}}" } + {{- end }} // Shamelessly copied from https://github.com/grafana/intro-to-mlt/blob/main/agent/config.river otelcol.receiver.otlp "otlp_receiver" { @@ -316,7 +322,7 @@ data: {{- if .Values.local.logs.enabled }} loki.write "local" { endpoint { - url = "http://loki-gateway.{{- .Release.Namespace -}}.svc.cluster.local:80/loki/api/v1/push" + url = "http://{{- .Release.Namespace -}}-loki-gateway.{{- .Release.Namespace -}}.svc.cluster.local:80/loki/api/v1/push" } } {{- end }} diff --git a/charts/meta-monitoring/templates/grafana/datasources.yaml b/charts/meta-monitoring/templates/grafana/datasources.yaml index f18076d..285be9a 100644 --- a/charts/meta-monitoring/templates/grafana/datasources.yaml +++ b/charts/meta-monitoring/templates/grafana/datasources.yaml @@ -12,7 +12,7 @@ data: # List of data sources to delete from the database. deleteDatasources: - - name: Loki + - name: Loki orgId: 1 # List of data sources to insert/update depending on what's @@ -32,7 +32,7 @@ data: uid: loki_ds # Sets the data source's URL, including the # port. - url: http://loki-gateway.{{- $.Release.Namespace -}}.svc.cluster.local + url: http://{{- $.Release.Namespace -}}-loki-gateway.{{- $.Release.Namespace -}}.svc.cluster.local # Toggles whether the data source is pre-selected # for new panels. You can set only one default # data source per organization.